bugfix: reduced mood loss due to bad sleep quality by 50%#28
Open
saibantes wants to merge 1 commit intoDigglesMods:masterfrom
Open
bugfix: reduced mood loss due to bad sleep quality by 50%#28saibantes wants to merge 1 commit intoDigglesMods:masterfrom
saibantes wants to merge 1 commit intoDigglesMods:masterfrom
Conversation
The previous code looks wrong, the portion calculating mood loss appears twice (two identical copies). This change removes one of the copies, thus reducing the mood loss by 50%. (Only applies to "sleep quality", i.e. the level of bedrooms.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code looks wrong, the portion calculating mood loss appears twice (two identical copies). This change removes one of the copies, thus reducing the mood loss by 50%. (Only applies to "sleep quality", i.e. the level of bedrooms.)
This fix deliberately removes the second of two identical code sections. Removing the first one instead would cause a conflict with the RevisedPlanner mod, which slightly changes the first section.